DOS ain't dead

DirectDrawSurface::Blt in MPlayer (Developers)

posted by Japheth , Germany (South), 11.04.2013, 15:01

> it's strange the same code does work on win32 and on wine, I'll try to
> investigate

Well, I was trying to tell that there might be a bug in the HX IDirectDrawSurface::Blt function.

Without a test case I can't do much - perhaps propose a possible fix?

Add the code in the "if 1 ... endif"-block to function Blt in surface.asm:


                                mov edx, [ecx].RECT.bottom
                                sub edx, [ecx].RECT.top
                                cmp edx, dwHeight
                                jnc @F
                                mov dwHeight, edx
@@:
if 1
                        .else
                                mov ecx,[esi].DDSF.dwWidth
                                cmp ecx, dwWidth
                                jnc @F
                                mov dwWidth, ecx
@@:
                                mov edx,[esi].DDSF.dwHeight
                                cmp edx, dwHeight
                                jnc @F
                                mov dwHeight, edx
@@:
endif
                        .endif
                        mov edx, [esi].DDSF.lPitch
                        mov esi, [esi].DDSF.lpSurface


---
MS-DOS forever!

Complete thread:

• DirectDrawSurface::Blt in MPlayer - sherpya, 07.04.2013, 08:49
  • DirectDrawSurface::Blt in MPlayer - Japheth, 09.04.2013, 20:10
    • DirectDrawSurface::Blt in MPlayer - sherpya, 11.04.2013, 13:44
      • DirectDrawSurface::Blt in MPlayer - Japheth, 11.04.2013, 15:01
  • DirectDrawSurface::Blt in MPlayer - DOS386, 10.04.2013, 11:47