DOS ain't dead

bug in NVclock ? (Developers)

posted by Laaca , Czech republic, 13.08.2009, 09:54

I rewrote some routines from NVClock into Freepascal and I think I found a bug in function vc_read_pbus16 in backend.c
It looks like this:

unsigned short nv_read_pbus16(int offset)
{
int shift = (offset / 2)*16;
return (nv_card->PBUS[offset/4] >> shift) & 0xffff;
}


But I think it should be corrected like this:
unsigned short nv_read_pbus16(int offset)
{
int shift = (offset % 2)*16;
return (nv_card->PBUS[offset/4] >> shift) & 0xffff;
}

---
DOS-u-akbar!

Complete thread:

• Rayer's NVclock - Laaca, 05.08.2009, 12:15
  • Rayer's NVclock - RayeR, 05.08.2009, 16:39
    • Rayer's NVclock - Laaca, 09.08.2009, 19:22
      • bug in NVclock ? - Laaca, 13.08.2009, 09:54